[Magick-bugs] Windows Configure Change Request: ( In file magick-config.h.in change default to #undef MAGICKCORE_X11_DELEGATE )

[Scott Callaway]

There are TWO items in this report/request -- labeled ITEM1 and ITEM2

########### 

I am using the latest source (ImageMagick-6.5.5-10.7z ) to build and test ImageMagick 
using Visual Studio 2008.

Using the default settings on win32, the 'validate.exe' test program fails 
and throws an exception (access violation) on line 431 of 'xwd.c'.

To reproduce this problem, with the configure.exe program,  accept the 
default settings in the 'magick-config.h.in' file AND enable the option 
"Include all demo, test, appl, and contrib directories".

Build the code and run the 'validate.exe' program.  You should see the 
access violation -- line 431 of 'xwd.c'

To resolve this issue, run the 'configure.exe' program and change the line from
   #define MAGICKCORE_X11_DELEGATE   --->  #undef MAGICKCORE_X11_DELEGATE

Clean and Recompile the code and the problem will go away.  The last two lines of 
output from 'validate.exe' are listed below:

  summary: 1 subtests; 4294967271 passed; 26 failed.
validation suite: 1926 tests; 1900 passed; 26 failed.

###########################  

## ITEM1:  ##
If you agree that the default win32 configuration should use the

#undef MAGICKCORE_X11_DELEGATE   setting, 

then make that change to the 'magick-config.h.in' file
AND please see the section below also.


#############################

The text in the 'magick-config.h.in' file discusses the MAGICKCORE_X11_DELEGATE
preprocessor symbol.  ( see below )

// Define if MIT X11 is available (or stubbed).  It is not actually
// necessary to use X11 or the X11 stubs library. The VisualMagick configure
// program assumes that X11 stubs is being used if X11 is not supported.
// To achieve a slimmer ImageMagick, undefine MAGICKCORE_X11_DELEGATE and
// remove the 'xlib' project from the ImageMagick workspace.
#undef MAGICKCORE_X11_DELEGATE

The instructions say if you use '#undef MAGICKCORE_X11_DELEGATE', then you should
remove the 'xlib' project from the workspace.

However, if you remove the 'CORE_xlib' project from the solution, the code will 
not build.  You will need to also remove the 'CORE_RL_xlib_.lib' and the
'CORE_DB_xlib_.lib' link dependencies from the 'analyze' project as well.  After you
remove these two link dependencies, the code will then build.

## ITEM2:  ##
Please evaluate if you believe this additional information should be 
added to the comments above the 'MAGICKCORE_X11_DELEGATE' section in 
the 'magick-config.h.in' file.

#######################

Thanks for all your hard work on this project.